Re: [RFC PATCH 08/11] target/ppc: wrapped some TCG only logic with ifdefs

[Bruno Piazera Larsen]

> > @@ -8799,7 +8803,9 @@ static void
> >         ppc_cpu_unrealize(DeviceState *dev)
> >         
> >                 cpu_remove_sync(CPU(cpu));
> >         
> >           +#ifdef CONFIG_TCG
> >         
> >               destroy_ppc_opcodes(cpu);
> >         
> >         +#endif
> >         
> >           }
> >         
> >             static gint ppc_cpu_compare_class_pvr(gconstpointer a,
> >         gconstpointer b)
> >         
> >         @@ -9297,7 +9303,9 @@ static void ppc_cpu_class_init(ObjectClass
> >         *oc, void *data)
> >         
> >               cc->class_by_name = ppc_cpu_class_by_name;
> >         
> >               cc->has_work = ppc_cpu_has_work;
> >         
> >               cc->dump_state = ppc_cpu_dump_state;
> >         
> >         +#ifdef CONFIG_TCG
> >         
> >               cc->dump_statistics = ppc_cpu_dump_statistics;
> >         
> >         +#endif
> >         
> >       
>       
>       We should just drop this entirely.  It's supposedly a generic
>       thing, but only used by ppc.  But even then only with source
>       modification to enable DO_PPC_STATISTICS.  And even then as we
>       convert to decodetree, said statistics will not be collected.
>       
>       
>       We should delete everything from cpu_dump_statistics on down.
>       
>

So, now that we have a version of disable-tcg that is functional, I'm inclined to look at this cleanup. Just to make sure I got it right: everything related to ppc_cpu_dump_statistics and the stuff related to ifdef DO_PPC_STATISTICS can be removed, yeah?

--
Bruno Piazera Larsen
Instituto de Pesquisas ELDORADO
Departamento Computação Embarcada
Analista de Software Trainee
Aviso Legal - Disclaimer