Re: [PATCH 24/24] target/ppc: Restrict ppc_cpu_tlb_fill to TCG

[Richard Henderson]

On 5/20/21 8:18 AM, Bruno Piazera Larsen wrote:
> > +#ifdef CONFIG_TCG
> >   bool ppc_cpu_tlb_fill(CPUState *cs, vaddr eaddr, int size,
> >                         MMUAccessType access_type, int mmu_idx,
> >                         bool probe, uintptr_t retaddr)
> > @@ -2984,3 +2985,4 @@ bool ppc_cpu_tlb_fill(CPUState *cs, vaddr eaddr, int size,
> >       raise_exception_err_ra(&cpu->env, cs->exception_index,
> >                              cpu->env.error_code, retaddr);
> >   }
> > +#endif
>
> This patch makes it look like we would compile mmu_helper.c after all. Is that 
> it? That looks like the simplest solution (ifdef'ing away all helpers) but I 
> thought mmu_helper was supposed to have all TCG-only code relating to MMU.

Yes, we will always compile mmu_helper.c. -- it was always going to have the 
stuff for gdbstub.

It was exc_helper which I was hoping for tcg-only (but then we decided that 
ifdefs were going to be the short-term solution).


r~