[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v2 1/7] target/ppc: fix ppc_store_sdr1 for user-only compilation
From: |
Bruno Larsen (billionai) |
Subject: |
[PATCH v2 1/7] target/ppc: fix ppc_store_sdr1 for user-only compilation |
Date: |
Tue, 18 May 2021 12:05:09 -0300 |
When the function was moved to cpu.c, it should have been wrapped with
#if !defined(CONFIG_USER_ONLY), otherwise linux-user builds don't work.
The cleanup suggested by Richard Henderson has also been applied,
changing error_report(...) to qemu_log_mask(LOG_GUEST_ERROR, ...) in
that function.
Signed-off-by: Bruno Larsen (billionai) <bruno.larsen@eldorado.org.br>
---
target/ppc/cpu.c | 10 ++++++----
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/target/ppc/cpu.c b/target/ppc/cpu.c
index 0ab7ac1af1..82e276349a 100644
--- a/target/ppc/cpu.c
+++ b/target/ppc/cpu.c
@@ -65,6 +65,7 @@ uint32_t ppc_get_vscr(CPUPPCState *env)
return env->vscr | (sat << VSCR_SAT);
}
+#if !defined(CONFIG_USER_ONLY)
void ppc_store_sdr1(CPUPPCState *env, target_ulong value)
{
PowerPCCPU *cpu = env_archcpu(env);
@@ -76,13 +77,13 @@ void ppc_store_sdr1(CPUPPCState *env, target_ulong value)
target_ulong htabsize = value & SDR_64_HTABSIZE;
if (value & ~sdr_mask) {
- error_report("Invalid bits 0x"TARGET_FMT_lx" set in SDR1",
- value & ~sdr_mask);
+ qemu_log_mask(LOG_GUEST_ERROR, "Invalid bits 0x"TARGET_FMT_lx
+ " set in SDR1", value & ~sdr_mask);
value &= sdr_mask;
}
if (htabsize > 28) {
- error_report("Invalid HTABSIZE 0x" TARGET_FMT_lx" stored in SDR1",
- htabsize);
+ qemu_log_mask(LOG_GUEST_ERROR, "Invalid HTABSIZE 0x" TARGET_FMT_lx
+ " stored in SDR1", htabsize);
return;
}
}
@@ -90,3 +91,4 @@ void ppc_store_sdr1(CPUPPCState *env, target_ulong value)
/* FIXME: Should check for valid HTABMASK values in 32-bit case */
env->spr[SPR_SDR1] = value;
}
+#endif
--
2.17.1
- [PATCH v2 0/7] target/ppc: Misc motion to support disabling TCG, Bruno Larsen (billionai), 2021/05/18
- [PATCH v2 1/7] target/ppc: fix ppc_store_sdr1 for user-only compilation,
Bruno Larsen (billionai) <=
- [PATCH v2 2/7] target/ppc: moved ppc_store_lpcr and ppc_store_msr to cpu.c, Bruno Larsen (billionai), 2021/05/18
- [PATCH v2 3/7] target/ppc: reduce usage of fpscr_set_rounding_mode, Bruno Larsen (billionai), 2021/05/18
- [PATCH v2 4/7] target/ppc: overhauled and moved logic of storing fpscr, Bruno Larsen (billionai), 2021/05/18
- [PATCH v2 5/7] target/ppc: removed unnecessary inclusion of helper-proto.h, Bruno Larsen (billionai), 2021/05/18
- [PATCH v2 6/7] target/ppc: moved ppc_cpu_do_interrupt to cpu.c, Bruno Larsen (billionai), 2021/05/18
- [PATCH v2 7/7] target/ppc: wrapped some TCG only logic with ifdefs, Bruno Larsen (billionai), 2021/05/18