Re: [PATCH v2 12/12] hw/ppc/Kconfig: Add dependency PEGASOS2 -> ATI_VGA

[Bin Meng]

On Sun, May 16, 2021 at 3:41 AM BALATON Zoltan <balaton@eik.bme.hu> wrote:
>
> On Sat, 15 May 2021, Philippe Mathieu-Daudé wrote:
> > From: Philippe Mathieu-Daudé <f4bug@amsat.org>
> >
> > While the ATI VGA device isn't a requisite (no crash without it):
> >
> >  $ qemu-system-ppc -M pegasos2
> >  qemu-system-ppc: standard VGA not available
> >
> > it is useful to have it with the Pegasos2 machine:
> >
> >  $ qemu-system-ppc -M pegasos2 -vga none -bios pegasos2.rom -device 
> > ati-vga,romfile=
> >  qemu-system-ppc: -device ati-vga,romfile=: 'ati-vga' is not a valid device 
> > model name
> >
> > Add it as an implicit Kconfig dependency.
> >
> > Fixes: ba7e5ac18e7 ("hw/ppc: Add emulation of Genesi/bPlan Pegasos II")
>
> You can list it as a fix but I regard this more an enhancement or
> amandment to that commit as it was not broken in this regard as the commit
> message above also explains. To me Fixes tag means more that something was

Agree. This patch is more like a feature, instead of a fix. So the
"Fixes" tag isn't appropriate.

> broken in that commit that this one patches up but I don't care much about
> this tag. It would probably make more sense in your other commits fixing
> missing dependencies (although not clear which commit those fix as the
> missing dependencies were probably also missing before the latest clean
> ups).
>
> > Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
>
> Acked-by: BALATON Zoltan <balaton@eik.bme.hu>

FWIW:

Reviewed-by: Bin Meng <bmeng.cn@gmail.com>

Regards,
Bin