[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 01/12] hw/mem/nvdimm: Use Kconfig 'imply' instead of 'depe
|
From: |
Bin Meng |
|
Subject: |
Re: [PATCH v2 01/12] hw/mem/nvdimm: Use Kconfig 'imply' instead of 'depends on' |
|
Date: |
Mon, 17 May 2021 10:33:39 +0800 |
On Sun, May 16, 2021 at 1:37 AM Philippe Mathieu-Daudé
<philmd@redhat.com> wrote:
>
> Per the kconfig.rst:
>
> A device should be listed [...] ``imply`` if (depending on
> the QEMU command line) the board may or may not be started
> without it.
>
> This is the case with the NVDIMM device (it is certainly possible
> to start a machine without NVDIMM) , so use the 'imply' weak
> reverse dependency to select the symbol.
>
> Acked-by: Paolo Bonzini <pbonzini@redhat.com>
> Acked-by: David Gibson <david@gibson.dropbear.id.au>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> default-configs/devices/ppc64-softmmu.mak | 1 -
> hw/arm/Kconfig | 1 +
> hw/i386/Kconfig | 1 +
> hw/mem/Kconfig | 2 --
> hw/ppc/Kconfig | 1 +
> 5 files changed, 3 insertions(+), 3 deletions(-)
>
Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
- [PATCH v2 00/12] hw: Various Kconfig fixes, Philippe Mathieu-Daudé, 2021/05/15
- [PATCH v2 01/12] hw/mem/nvdimm: Use Kconfig 'imply' instead of 'depends on', Philippe Mathieu-Daudé, 2021/05/15
- Re: [PATCH v2 01/12] hw/mem/nvdimm: Use Kconfig 'imply' instead of 'depends on',
Bin Meng <=
- [PATCH v2 02/12] hw/ide/Kconfig: Add missing dependency PCI -> IDE_QDEV, Philippe Mathieu-Daudé, 2021/05/15
- [PATCH v2 03/12] hw/arm/Kconfig: Add missing dependency NPCM7XX -> SMBUS, Philippe Mathieu-Daudé, 2021/05/15
- [PATCH v2 04/12] hw/arm/Kconfig: Remove unused DS1338 symbol from i.MX25 PDK Board, Philippe Mathieu-Daudé, 2021/05/15
- [PATCH v2 05/12] hw/arm/Kconfig: Add missing SDHCI symbol to FSL_IMX25, Philippe Mathieu-Daudé, 2021/05/15
- [PATCH v2 06/12] hw/riscv/Kconfig: Add missing dependency MICROCHIP_PFSOC -> SERIAL, Philippe Mathieu-Daudé, 2021/05/15
- [PATCH v2 07/12] hw/riscv/Kconfig: Restrict NUMA to Virt & Spike machines, Philippe Mathieu-Daudé, 2021/05/15