[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 04/11] target/ppc: moved ppc_store_msr into gdbstub.c
|
From: |
David Gibson |
|
Subject: |
Re: [PATCH 04/11] target/ppc: moved ppc_store_msr into gdbstub.c |
|
Date: |
Thu, 13 May 2021 13:52:30 +1000 |
On Wed, May 12, 2021 at 12:05:04PM -0500, Richard Henderson wrote:
> On 5/12/21 9:08 AM, Bruno Larsen (billionai) wrote:
> > This function is used by !TCG cases, so it was moved to a common code
> > file. We chose gdbstub.c since it was the one giving us grief over it.
> >
> > Signed-off-by: Bruno Larsen (billionai)<bruno.larsen@eldorado.org.br>
> > ---
> > target/ppc/gdbstub.c | 7 +++++++
> > target/ppc/misc_helper.c | 6 ------
> > 2 files changed, 7 insertions(+), 6 deletions(-)
>
> gdbstub.c is not the only !tcg user; e.g. machine.c.
>
> I think this should go in cpu.c, next to the other special register
> read/write functions.
I agree.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
signature.asc
Description: PGP signature
- Re: [PATCH 01/11] target/ppc: created ppc_{store,get}_vscr for generic vscr usage, (continued)
- [PATCH 02/11] target/ppc: moved ppc_store_sdr1 to cpu.c, Bruno Larsen (billionai), 2021/05/12
- [PATCH 03/11] target/ppc: moved ppc_cpu_dump_state to cpu_init.c, Bruno Larsen (billionai), 2021/05/12
- [PATCH 04/11] target/ppc: moved ppc_store_msr into gdbstub.c, Bruno Larsen (billionai), 2021/05/12
- [PATCH 05/11] target/ppc: moved ppc_store_lpcr to cpu.c, Bruno Larsen (billionai), 2021/05/12
- [PATCH 06/11] target/ppc: updated vscr manipulation in machine.c, Bruno Larsen (billionai), 2021/05/12
- [PATCH 07/11] target/ppc: added KVM fallback to fpscr manipulation, Bruno Larsen (billionai), 2021/05/12