[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 14/17] hw/misc/pca9552: Replace g_newa() by g_new()
|
From: |
Cédric Le Goater |
|
Subject: |
Re: [PATCH v3 14/17] hw/misc/pca9552: Replace g_newa() by g_new() |
|
Date: |
Mon, 10 May 2021 07:59:37 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 |
On 5/7/21 4:43 PM, Philippe Mathieu-Daudé wrote:
> The ALLOCA(3) man-page mentions its "use is discouraged".
>
> Use autofree heap allocation instead, replacing g_newa() by g_new().
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Cédric Le Goater <clg@kaod.org>
> ---
> hw/misc/pca9552.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/misc/pca9552.c b/hw/misc/pca9552.c
> index b7686e27d7f..facf103cbfb 100644
> --- a/hw/misc/pca9552.c
> +++ b/hw/misc/pca9552.c
> @@ -71,7 +71,7 @@ static void pca955x_display_pins_status(PCA955xState *s,
> return;
> }
> if (trace_event_get_state_backends(TRACE_PCA955X_GPIO_STATUS)) {
> - char *buf = g_newa(char, k->pin_count + 1);
> + g_autofree char *buf = g_new(char, k->pin_count + 1);
>
> for (i = 0; i < k->pin_count; i++) {
> if (extract32(pins_status, i, 1)) {
>
- [PATCH v3 07/17] linux-user: Replace alloca() by g_try_malloc() in various socket syscall, (continued)
- [PATCH v3 07/17] linux-user: Replace alloca() by g_try_malloc() in various socket syscall, Philippe Mathieu-Daudé, 2021/05/07
- [PATCH v3 08/17] linux-user/syscall: Move code around in do_sendrecvmsg_locked(), Philippe Mathieu-Daudé, 2021/05/07
- [PATCH v3 10/17] audio/alsaaudio: Replace ALSA alloca() by malloc() equivalent, Philippe Mathieu-Daudé, 2021/05/07
- [PATCH v3 09/17] linux-user/syscall: Replace alloca() by GLib alloc() in sendrecvmsg, Philippe Mathieu-Daudé, 2021/05/07
- [PATCH v3 11/17] backends/tpm: Replace g_alloca() by g_malloc(), Philippe Mathieu-Daudé, 2021/05/07
- [PATCH v3 12/17] gdbstub: Constify GdbCmdParseEntry, Philippe Mathieu-Daudé, 2021/05/07
- [PATCH v3 15/17] target/ppc/kvm: Replace alloca() by g_malloc(), Philippe Mathieu-Daudé, 2021/05/07
- [PATCH v3 13/17] gdbstub: Replace GdbCmdContext with plain g_array(), Philippe Mathieu-Daudé, 2021/05/07
- [PATCH v3 14/17] hw/misc/pca9552: Replace g_newa() by g_new(), Philippe Mathieu-Daudé, 2021/05/07
- Re: [PATCH v3 14/17] hw/misc/pca9552: Replace g_newa() by g_new(),
Cédric Le Goater <=
- [NOTFORMERGE PATCH v3 17/17] configure: libSLiRP buildsys kludge, Philippe Mathieu-Daudé, 2021/05/07
- [PATCH v3 16/17] configure: Prohibit alloca() by using -Walloca CPPFLAG, Philippe Mathieu-Daudé, 2021/05/07