Re: [PATCH 07/23] hw/block/nvme: Use definition to avoid dynamic stack allocation

[Klaus Jensen]

On May  5 23:10, Philippe Mathieu-Daudé wrote:
> The compiler isn't clever enough to figure 'SEG_CHUNK_SIZE' is
> a constant! Help it by using a definitions instead.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> hw/block/nvme.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/block/nvme.c b/hw/block/nvme.c
> index 5fe082ec34c..2f6d4925826 100644
> --- a/hw/block/nvme.c
> +++ b/hw/block/nvme.c
> @@ -812,7 +812,7 @@ static uint16_t nvme_map_sgl(NvmeCtrl *n, NvmeSg *sg, 
> NvmeSglDescriptor sgl,
>      * descriptors and segment chain) than the command transfer size, so it is
>      * not bounded by MDTS.
>      */
> -    const int SEG_CHUNK_SIZE = 256;
> +#define SEG_CHUNK_SIZE 256
>
>     NvmeSglDescriptor segment[SEG_CHUNK_SIZE], *sgld, *last_sgld;
>     uint64_t nsgld;
> --
> 2.26.3

Reviewed-by: Klaus Jensen <k.jensen@samsung.com>

signature.asc
Description: PGP signature