Re: [PATCH v3 26/30] target/ppc: Implement PNOP

[Philippe Mathieu-Daudé]

On 4/30/21 3:15 AM, Richard Henderson wrote:
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
>  target/ppc/insn32.decode                   |  2 ++
>  target/ppc/insn64.decode                   | 11 +++++++++++
>  target/ppc/translate/fixedpoint-impl.c.inc |  5 +++++
>  3 files changed, 18 insertions(+)
> 
> diff --git a/target/ppc/insn32.decode b/target/ppc/insn32.decode
> index 52d9b355d4..2ed25c7e67 100644
> --- a/target/ppc/insn32.decode
> +++ b/target/ppc/insn32.decode
> @@ -17,6 +17,8 @@
>  # License along with this library; if not, see 
> <http://www.gnu.org/licenses/>.
>  #
>  
> +&empty
> +

> +static bool trans_NOP(DisasContext *ctx, arg_NOP *a)

Matter of taste, I'd rather use 'arg_empty'.

> +{
> +    return true;
> +}
> 

Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>