|
From: | Richard Henderson |
Subject: | Re: [PATCH 5/5] target/ppc: Implement paddi and replace addi insns |
Date: | Wed, 14 Apr 2021 16:07:47 -0700 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 |
On 4/14/21 12:11 PM, Richard Henderson wrote:
static bool allow_prefix_MLS(DisasContext *ctx, arg_D *a) { int64_t imm; /* Require MLS prefix or no prefix. */ if (ctx->prefix_type != PREFIX_MLS) { if (ctx->prefix_type == PREFIX_NONE) { return true; } gen_invalid(ctx); return false; }
Combined with the switch on prefix_type in translate_insn, I think this can just simplify to
if (ctx->prefix_type != PREFIX_MLS) { return ctx->prefix_type == PREFIX_NONE; } because decode_legacy is only called from within PREFIX_NONE. r~
[Prev in Thread] | Current Thread | [Next in Thread] |