Re: [PATCH v3] target/ppc: code motion from translate_init.c.inc to gdbstub.c

[Richard Henderson]

On 4/14/21 7:59 AM, Bruno Larsen (billionai) wrote:
> All the code related to gdb has been moved from translate_init.c.inc
> file to the gdbstub.c file, where it makes more sense.
>
> This new version puts the prototypes in internal.h, to not expose
> them unnecessarily.
>
> Signed-off-by: Bruno Larsen (billionai) <bruno.larsen@eldorado.org.br>
> Suggested-by: Fabiano Rosas <farosas@linux.ibm.com>
> ---
>   target/ppc/gdbstub.c            | 258 ++++++++++++++++++++++++++++++++
>   target/ppc/internal.h           |   5 +
>   target/ppc/translate_init.c.inc | 254 +------------------------------
>   3 files changed, 264 insertions(+), 253 deletions(-)

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

> +void ppc_gdb_init(CPUState *cs, PowerPCCPUClass *pcc)
> +{
> +
> +    if (pcc->insns_flags & PPC_FLOAT) {

Watch the extra blank lines.


r~