[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] hw/net: fsl_etsec: Tx padding length should exclude CRC
|
From: |
Bin Meng |
|
Subject: |
Re: [PATCH] hw/net: fsl_etsec: Tx padding length should exclude CRC |
|
Date: |
Mon, 22 Mar 2021 12:33:06 +0800 |
Hi David,
On Mon, Mar 22, 2021 at 12:11 PM David Gibson
<david@gibson.dropbear.id.au> wrote:
>
> On Tue, Mar 16, 2021 at 04:15:05PM +0800, Bin Meng wrote:
> > As the comment of tx_padding_and_crc() says: "Never add CRC in QEMU",
> > min_frame_len should excluce CRC, so it should be 60 instead of 64.
>
> Sorry, your reasoning still isn't clear to me. If qemu is not adding
> the CRC, what is?
No one is padding CRC in QEMU. QEMU network backends pass payload
without CRC in between.
> Will it always append a CRC after this padding is complete?
No.
Regards,
Bin
Re: [PATCH] hw/net: fsl_etsec: Tx padding length should exclude CRC, David Gibson, 2021/03/22