|
From: | Cédric Le Goater |
Subject: | Re: [PATCH 2/5] hw/arm/aspeed: Do not sysbus-map mmio flash region directly, use alias |
Date: | Wed, 17 Mar 2021 20:03:12 +0100 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 |
On 3/17/21 8:00 PM, Philippe Mathieu-Daudé wrote: > On 3/17/21 7:30 PM, Cédric Le Goater wrote: >> On 3/12/21 7:28 PM, Philippe Mathieu-Daudé wrote: >>> The flash mmio region is exposed as an AddressSpace. >>> AddressSpaces must not be sysbus-mapped, therefore map >>> the region using an alias. >>> >>> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org> >> >> That does the trick but you need an extra change in the model. >> >> The fixes are in my aspeed-6.0 branch on GH and they survive the last >> patch of your series : >> >> [PATCH 5/5] memory: Make sure root MR won't be added as subregion > > I wondered about changing DMA_FLASH_ADDR() wasn't sure the tests > would use the flash. The acceptance tests (not merged yet) download firmware images in which u-boot does DMA accesses to calibrate the reads on the flash device. C. > >> I will upstream for 6.1. > > Thanks! > > Phil. >
[Prev in Thread] | Current Thread | [Next in Thread] |