[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v6 4/8] vt82c686: Introduce abstract TYPE_VIA_ISA and base vt
|
From: |
Philippe Mathieu-Daudé |
|
Subject: |
Re: [PATCH v6 4/8] vt82c686: Introduce abstract TYPE_VIA_ISA and base vt82c686b_isa on it |
|
Date: |
Wed, 10 Mar 2021 01:02:27 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.0 |
On 3/9/21 9:28 PM, BALATON Zoltan wrote:
> To allow reusing ISA bridge emulation for vt8231_isa move the device
> state of vt82c686b_isa emulation in an abstract via_isa class. This
> change breaks migration back compatibility but this is not an issue
> for Fuloong2E machine which is not versioned or migration supported.
>
> Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
> ---
> hw/isa/vt82c686.c | 70 ++++++++++++++++++++++------------------
> include/hw/pci/pci_ids.h | 2 +-
> 2 files changed, 40 insertions(+), 32 deletions(-)
This should be OK if this other series is accepted:
"hw/usb: Extract Extract VT82C686 UHCI PCI function into new unit"
https://lists.gnu.org/archive/html/qemu-devel/2021-03/msg03083.html
I'll come back to this patch after the former series is reviewed.
- [PATCH v6 0/8] Pegasos2 emulation, BALATON Zoltan, 2021/03/09
- [PATCH v6 5/8] vt82c686: Add emulation of VT8231 south bridge, BALATON Zoltan, 2021/03/09
- [PATCH v6 6/8] hw/isa/Kconfig: Add missing dependency VIA VT82C686 -> APM, BALATON Zoltan, 2021/03/09
- [PATCH v6 3/8] vt82c686: Add VT8231_SUPERIO based on VIA_SUPERIO, BALATON Zoltan, 2021/03/09
- [PATCH v6 4/8] vt82c686: Introduce abstract TYPE_VIA_ISA and base vt82c686b_isa on it, BALATON Zoltan, 2021/03/09
- Re: [PATCH v6 4/8] vt82c686: Introduce abstract TYPE_VIA_ISA and base vt82c686b_isa on it,
Philippe Mathieu-Daudé <=
- [PATCH v6 2/8] vt82c686: QOM-ify superio related functionality, BALATON Zoltan, 2021/03/09
- [PATCH v6 8/8] hw/ppc: Add emulation of Genesi/bPlan Pegasos II, BALATON Zoltan, 2021/03/09
- [PATCH v6 1/8] vt82c686: Implement control of serial port io ranges via config regs, BALATON Zoltan, 2021/03/09
- [PATCH v6 7/8] hw/pci-host: Add emulation of Marvell MV64361 PPC system controller, BALATON Zoltan, 2021/03/09