Re: [PATCH v4 5/6] hw/pci-host: Add emulation of Marvell MV64361 PPC system controller

[BALATON Zoltan]

On Tue, 2 Mar 2021, Philippe Mathieu-Daudé wrote:
> On 2/25/21 8:47 PM, BALATON Zoltan wrote:
> > The Marvell Discovery II aka. MV64361 is a PowerPC system controller
> > chip that is used on the pegasos2 PPC board. This adds emulation of it
> > that models the device enough to boot guests on this board. The
> > mv643xx.h header with register definitions is taken from Linux 4.15.10
> > only fixing end of line white space errors and removing not needed
> > parts, it's otherwise keeps Linux formatting.
> >
> > Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
> > ---
> >  hw/pci-host/Kconfig           |   3 +
> >  hw/pci-host/meson.build       |   2 +
> >  hw/pci-host/mv64361.c         | 966 ++++++++++++++++++++++++++++++++++
> >  hw/pci-host/mv643xx.h         | 919 ++++++++++++++++++++++++++++++++
>
> Maybe name this one mv643xx_regs.h?

This comes originally from Linux where it had this name so to make it 
simpler to find where it comes from I've kept the name for now. If we 
ever change the contents beyond just formatting it could be renamed too.

Regards,
BALATON Zoltan

> >  hw/pci-host/trace-events      |   6 +
> >  include/hw/pci-host/mv64361.h |   8 +
> >  include/hw/pci/pci_ids.h      |   1 +
> >  7 files changed, 1905 insertions(+)
> >  create mode 100644 hw/pci-host/mv64361.c
> >  create mode 100644 hw/pci-host/mv643xx.h
> >  create mode 100644 include/hw/pci-host/mv64361.h
>
> > diff --git a/hw/pci-host/Kconfig b/hw/pci-host/Kconfig
> > index 8b8c763c28..65a983d6fd 100644
> > --- a/hw/pci-host/Kconfig
> > +++ b/hw/pci-host/Kconfig
> > @@ -68,3 +68,6 @@ config PCI_POWERNV
> >
> >  config REMOTE_PCIHOST
> >      bool
> > +
> > +config MV64361
> > +    bool
>
> Missing:
>
>       select PCI