[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PULL 33/43] target/ppc: convert xxspltw to vector operations
|
From: |
Richard Henderson |
|
Subject: |
Re: [PULL 33/43] target/ppc: convert xxspltw to vector operations |
|
Date: |
Fri, 6 Nov 2020 11:44:12 -0800 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 |
On 11/6/20 10:47 AM, Peter Maydell wrote:
>> +#ifndef HOST_WORDS_BIG_ENDIAN
>> + bofs ^= 8 | 4;
>> +#endif
>
> The ifdef is HOST_WORDS_BIGENDIAN without the
> third underscore, so this XOR operation will be
> done on both little and big-endian hosts.
Ho hum.
> Should the ifndef line be fixed...
This.
I once had a patch set that changed all of our endian tests from defined/undef
to true/false, so that we could detect errors like this. Perhaps I'll try to
recreate it next dev cycle...
r~