[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v8 3/5] mac_oldworld: Drop a variable, use get_system_memory() di
From: |
BALATON Zoltan |
Subject: |
[PATCH v8 3/5] mac_oldworld: Drop a variable, use get_system_memory() directly |
Date: |
Fri, 16 Oct 2020 01:47:17 +0200 |
Half of the occurances already use get_system_memory() directly
instead of sysmem variable, convert the two other uses to
get_system_memory() too which seems to be more common and drop the
variable.
Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
Reviewed-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
hw/ppc/mac_oldworld.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/hw/ppc/mac_oldworld.c b/hw/ppc/mac_oldworld.c
index 0a40769b3e..5b30fa0739 100644
--- a/hw/ppc/mac_oldworld.c
+++ b/hw/ppc/mac_oldworld.c
@@ -87,7 +87,6 @@ static void ppc_heathrow_init(MachineState *machine)
const char *kernel_cmdline = machine->kernel_cmdline;
const char *initrd_filename = machine->initrd_filename;
const char *boot_device = machine->boot_order;
- MemoryRegion *sysmem = get_system_memory();
PowerPCCPU *cpu = NULL;
CPUPPCState *env = NULL;
char *filename;
@@ -129,12 +128,12 @@ static void ppc_heathrow_init(MachineState *machine)
exit(1);
}
- memory_region_add_subregion(sysmem, 0, machine->ram);
+ memory_region_add_subregion(get_system_memory(), 0, machine->ram);
/* allocate and load firmware ROM */
memory_region_init_rom(bios, NULL, "ppc_heathrow.bios", PROM_SIZE,
&error_fatal);
- memory_region_add_subregion(sysmem, PROM_BASE, bios);
+ memory_region_add_subregion(get_system_memory(), PROM_BASE, bios);
if (!bios_name) {
bios_name = PROM_FILENAME;
--
2.21.3
- [PATCH v8 0/5] Mac Old World ROM experiment (ppc/mac_* clean ups and loading binary ROM), BALATON Zoltan, 2020/10/15
- [PATCH v8 4/5] mac_oldworld: Drop some variables, BALATON Zoltan, 2020/10/15
- [PATCH v8 3/5] mac_oldworld: Drop a variable, use get_system_memory() directly,
BALATON Zoltan <=
- [PATCH v8 2/5] mac_newworld: Allow loading binary ROM image, BALATON Zoltan, 2020/10/15
- [PATCH v8 5/5] mac_oldworld: Change PCI address of macio to match real hardware, BALATON Zoltan, 2020/10/15
- [PATCH v8 1/5] mac_oldworld: Allow loading binary ROM image, BALATON Zoltan, 2020/10/15
- Re: [PATCH v8 0/5] Mac Old World ROM experiment (ppc/mac_* clean ups and loading binary ROM), Mark Cave-Ayland, 2020/10/16
- Re: [PATCH v8 0/5] Mac Old World ROM experiment (ppc/mac_* clean ups and loading binary ROM), Philippe Mathieu-Daudé, 2020/10/16