Re: [PATCH v2 2/3] grackle: use qdev gpios for PCI IRQs

[Mark Cave-Ayland]

On 13/10/2020 18:05, BALATON Zoltan via wrote:

> Hello,
>
> Not related to this patch but while you're at it could you please take those patches 
> that are already reviewed by you from this series as well?
>
> http://patchwork.ozlabs.org/project/qemu-devel/list/?series=186439
>
> That would help cleaning up my tree and see which patches still need changes. Let me 
> know if these need any rebasing and point me to the tree on which I should rebase 
> them. Currently they apply to your screamer branch I think.

I've queued the grackle/uninorth patches to my qemu-macppc branch, however when I try 
to apply patches from the above series git fails with the following message:

Applying: mac_oldworld: Drop a variable, use get_system_memory() directly
error: sha1 information is lacking or useless (hw/ppc/mac_oldworld.c).
error: could not build fake ancestor

Any chance you can rebase and repost? I'm happy to take patches 3 and 4, and if my 
suggestion of casting the return address via target_ulong works then I think 1 and 2 
are also fine. The I2C stuff I can't really review, and weren't there still issues 
with the SPD data in patch 8 reporting the wrong RAM size?


ATB,

Mark.