|
From: | Paolo Bonzini |
Subject: | Re: [PATCH] hw/net: move allocation to the heap due to very large stack frame |
Date: | Mon, 12 Oct 2020 15:45:02 +0200 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 |
On 12/10/20 12:44, Thomas Huth wrote: > I think this is one of the tasks from: > > https://wiki.qemu.org/Contribute/BiteSizedTasks#Compiler-driven_cleanups > > It has been added by Paolo in 2016: > > > https://wiki.qemu.org/index.php?title=Contribute/BiteSizedTasks&diff=5368&oldid=5367 > > ... so maybe Paolo can comment on the size that has been chosen here...? I used 16K, mostly because it is a nice round number. 8k is too small due to PATH_MAX-sized variables. 16k seemed to be plenty and triggered in few-enough places that the cleanup is viable. Paolo
[Prev in Thread] | Current Thread | [Next in Thread] |