[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 1/9] target/arm: Move start-powered-off property to generi
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [PATCH v2 1/9] target/arm: Move start-powered-off property to generic CPUState |
Date: |
Wed, 22 Jul 2020 08:52:43 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 |
Hi Thiago,
On 7/22/20 5:50 AM, Thiago Jung Bauermann wrote:
> There are other platforms which also have CPUs that start powered off, so
> generalize the start-powered-off property so that it can be used by them.
>
> Note that ARMv7MState also has a property of the same name but this patch
> doesn't change it because that class isn't a subclass of CPUState so it
> wouldn't be a trivial change.
>
> This change should not cause any change in behavior.
>
> Suggested-by: Eduardo Habkost <ehabkost@redhat.com>
> Signed-off-by: Thiago Jung Bauermann <bauerman@linux.ibm.com>
As I participated in reviewing your v1, I'd have appreciated
being Cc'ed for v2.
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> exec.c | 1 +
> include/hw/core/cpu.h | 4 ++++
> target/arm/cpu.c | 5 ++---
> target/arm/cpu.h | 3 ---
> target/arm/kvm32.c | 2 +-
> target/arm/kvm64.c | 2 +-
> 6 files changed, 9 insertions(+), 8 deletions(-)