[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[RFC PATCH v2 10/23] hw/display/vga-isa-mm: Emit warning when old code i
From: |
Philippe Mathieu-Daudé |
Subject: |
[RFC PATCH v2 10/23] hw/display/vga-isa-mm: Emit warning when old code is used |
Date: |
Sat, 4 Jul 2020 17:38:55 +0200 |
This code hasn't been QOM'ified yet. Warn the user.
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
hw/display/vga-isa-mm.c | 5 +++++
hw/display/vga.c | 3 +++
2 files changed, 8 insertions(+)
diff --git a/hw/display/vga-isa-mm.c b/hw/display/vga-isa-mm.c
index 7321b7a06d..3e62389b63 100644
--- a/hw/display/vga-isa-mm.c
+++ b/hw/display/vga-isa-mm.c
@@ -29,6 +29,7 @@
#include "hw/display/vga.h"
#include "vga_int.h"
#include "ui/pixel_ops.h"
+#include "hw/qdev-deprecated.h"
#define VGA_RAM_SIZE (8 * MiB)
@@ -71,6 +72,8 @@ static void vga_mm_init(ISAVGAMMState *s, hwaddr vram_base,
{
MemoryRegion *s_ioport_ctrl, *vga_io_memory;
+ qdev_warn_deprecated_function_used();
+
s->it_shift = it_shift;
s_ioport_ctrl = g_malloc(sizeof(*s_ioport_ctrl));
memory_region_init_io(s_ioport_ctrl, NULL, &vga_mm_ctrl_ops, s,
@@ -99,6 +102,8 @@ int isa_vga_mm_init(hwaddr vram_base,
s = g_malloc0(sizeof(*s));
+ qdev_warn_deprecated_function_used();
+
s->vga.vram_size_mb = VGA_RAM_SIZE / MiB;
s->vga.global_vmstate = true;
vga_common_init(&s->vga, NULL);
diff --git a/hw/display/vga.c b/hw/display/vga.c
index 061fd9ab8f..d59a9c896b 100644
--- a/hw/display/vga.c
+++ b/hw/display/vga.c
@@ -35,6 +35,7 @@
#include "hw/xen/xen.h"
#include "migration/vmstate.h"
#include "trace.h"
+#include "hw/qdev-deprecated.h"
//#define DEBUG_VGA_MEM
//#define DEBUG_VGA_REG
@@ -2262,6 +2263,8 @@ MemoryRegion *vga_init_io(VGACommonState *s, Object *obj,
{
MemoryRegion *vga_mem;
+ qdev_warn_deprecated_function_used();
+
*vga_ports = vga_portio_list;
*vbe_ports = vbe_portio_list;
--
2.21.3
- Re: [RFC PATCH v2 02/23] hw/core/qdev: Add qdev_warn_deprecated_function_used() helper, (continued)
- [RFC PATCH v2 03/23] hw/arm/omap: Emit warning when old code is used, Philippe Mathieu-Daudé, 2020/07/04
- [RFC PATCH v2 04/23] hw/arm/pxa2xx: Emit warning when old code is used, Philippe Mathieu-Daudé, 2020/07/04
- [RFC PATCH v2 06/23] hw/char/parallel: Emit warning when old code is used, Philippe Mathieu-Daudé, 2020/07/04
- [RFC PATCH v2 05/23] hw/arm/nseries: Emit warning when old code is used, Philippe Mathieu-Daudé, 2020/07/04
- [RFC PATCH v2 07/23] hw/display/blizzard: Emit warning when old code is used, Philippe Mathieu-Daudé, 2020/07/04
- [RFC PATCH v2 08/23] hw/display/ramfb: Emit warning when old code is used, Philippe Mathieu-Daudé, 2020/07/04
- [RFC PATCH v2 09/23] hw/display/tc6393xb: Emit warning when old code is used, Philippe Mathieu-Daudé, 2020/07/04
- [RFC PATCH v2 10/23] hw/display/vga-isa-mm: Emit warning when old code is used,
Philippe Mathieu-Daudé <=
- [RFC PATCH v2 11/23] hw/dma/etraxfs_dma: Emit warning when old code is used, Philippe Mathieu-Daudé, 2020/07/04
- [RFC PATCH v2 13/23] hw/input/lasips2: Emit warning when old code is used, Philippe Mathieu-Daudé, 2020/07/04
- [RFC PATCH v2 12/23] hw/dma/soc_dma: Emit warning when old code is used, Philippe Mathieu-Daudé, 2020/07/04
- [RFC PATCH v2 14/23] hw/input/tsc2005: Emit warning when old code is used, Philippe Mathieu-Daudé, 2020/07/04
- [RFC PATCH v2 15/23] hw/m68k/mcf520x: Emit warning when old code is used, Philippe Mathieu-Daudé, 2020/07/04
- [RFC PATCH v2 16/23] hw/misc/cbus: Emit warning when old code is used, Philippe Mathieu-Daudé, 2020/07/04
- [RFC PATCH v2 17/23] hw/nvram/eeprom93xx: Emit warning when old code is used, Philippe Mathieu-Daudé, 2020/07/04
- [RFC PATCH v2 18/23] hw/openrisc/cputimer: Emit warning when old code is used, Philippe Mathieu-Daudé, 2020/07/04