Re: [PATCH v5 05/11] grackle: Set revision in PCI config to match hardware

[Mark Cave-Ayland]

On 16/06/2020 14:47, BALATON Zoltan wrote:

> Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
> ---
>  hw/pci-host/grackle.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/hw/pci-host/grackle.c b/hw/pci-host/grackle.c
> index 4b3af0c704..48d11f13ab 100644
> --- a/hw/pci-host/grackle.c
> +++ b/hw/pci-host/grackle.c
> @@ -130,7 +130,7 @@ static void grackle_pci_class_init(ObjectClass *klass, 
> void *data)
>      k->realize   = grackle_pci_realize;
>      k->vendor_id = PCI_VENDOR_ID_MOTOROLA;
>      k->device_id = PCI_DEVICE_ID_MOTOROLA_MPC106;
> -    k->revision  = 0x00;
> +    k->revision  = 0x40;
>      k->class_id  = PCI_CLASS_BRIDGE_HOST;
>      /*
>       * PCI-facing part of the host bridge, not usable without the

It seems the current value is 0x0, but in one of my dumps I see a value of 0x1, 
and
you're suggesting a value of 0x40. Given that there are clearly multiple 
revisions of
the hardware, I'd suggest dropping this for now since it's not clear to me yet
exactly which real hardware is being targetted and what side-effect this might 
have.


ATB,

Mark.