[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 12/19] audio: add soundhw deprecation notice
From: |
Gerd Hoffmann |
Subject: |
Re: [PATCH v3 12/19] audio: add soundhw deprecation notice |
Date: |
Mon, 22 Jun 2020 14:12:57 +0200 |
On Mon, Jun 22, 2020 at 12:42:54PM +0100, Daniel P. Berrangé wrote:
> On Mon, Jun 22, 2020 at 01:29:07PM +0200, Gerd Hoffmann wrote:
> > Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> > ---
> > docs/system/deprecated.rst | 9 +++++++++
> > 1 file changed, 9 insertions(+)
> >
> > diff --git a/docs/system/deprecated.rst b/docs/system/deprecated.rst
> > index 3a255591c341..7ddd9e400745 100644
> > --- a/docs/system/deprecated.rst
> > +++ b/docs/system/deprecated.rst
> > @@ -82,6 +82,15 @@ should specify an ``audiodev=`` property. Additionally,
> > when using
> > vnc, you should specify an ``audiodev=`` propery if you plan to
> > transmit audio through the VNC protocol.
> >
> > +Creating sound card devices using ``-soundhw`` (since 5.1)
> > +''''''''''''''''''''''''''''''''''''''''''''''''''''''''''
> > +
> > +Sound card devices should be created using ``-device`` instead. The
> > +names are the same for most devices. The exceptions are ``hda`` which
> > +needs two devices (``-device intel-hda --device hda-duplex``) and
> > +``pcspk`` which can be activated using ``-global
> > +pcspk.audiodev=<name>``.
>
> The previous "-soundhw pcspk" didn't include any audiodev specification,
> so I presume it activated some kind of default ?
Yes. First audiodev it finds.
Before -audiodev arrived you could not have multiple backends in the
first place, so this covers backward compatibility with existing
configurations.
> What would be the equivalent audiodev to specify for the new arg to
> match the old default ?
Doesn't exist. You have to explicitly create an audiodev backend.
See also patch 19/19 which adds "-machine pcspk-audidev=<name>", that'll
probably more useful for libvirt because (a) -global should be avoided
anyway and (b) you can see the new machine property in qapi introspection
and pick pcspk init code path based on that.
take care,
Gerd
[PATCH v3 12/19] audio: add soundhw deprecation notice, Gerd Hoffmann, 2020/06/22
[PATCH v3 19/19] audio: set default value for pcspk.iobase property, Gerd Hoffmann, 2020/06/22
[PATCH v3 06/19] audio: deprecate -soundhw adlib, Gerd Hoffmann, 2020/06/22
[PATCH v3 08/19] audio: deprecate -soundhw gus, Gerd Hoffmann, 2020/06/22
[PATCH v3 05/19] audio: deprecate -soundhw es1370, Gerd Hoffmann, 2020/06/22
[PATCH v3 07/19] audio: deprecate -soundhw cs4231a, Gerd Hoffmann, 2020/06/22
[PATCH v3 09/19] audio: deprecate -soundhw sb16, Gerd Hoffmann, 2020/06/22