Re: [RESEND PATCH v3 1/1] ppc/spapr: Add hotremovable flag on DIMM LMBs on drmem_v2

[David Gibson]

On Thu, May 14, 2020 at 08:05:17AM +0200, Cédric Le Goater wrote:
> >> --- a/hw/ppc/spapr.c
> >> +++ b/hw/ppc/spapr.c
> >> @@ -446,7 +446,8 @@ static int 
> >> spapr_dt_dynamic_memory_v2(SpaprMachineState *spapr, void *fdt,
> >>          g_assert(drc);
> >>          elem = spapr_get_drconf_cell(size / lmb_size, addr,
> >>                                       spapr_drc_index(drc), node,
> >> -                                     SPAPR_LMB_FLAGS_ASSIGNED);
> >> +                                     (SPAPR_LMB_FLAGS_ASSIGNED |
> >> +                                      SPAPR_LMB_FLAGS_HOTREMOVABLE);
> 
> 
> This is missing a ')'

So it is.  I've corrected this in my tree, but please do compile test
your patches before sending.

-- 
David Gibson                    | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au  | minimalist, thank you.  NOT _the_ _other_
                                | _way_ _around_!
http://www.ozlabs.org/~dgibson

signature.asc
Description: PGP signature