[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v2 5/6] target/ppc: Fix arguments to ppc_radix64_partition_scoped
From: |
Greg Kurz |
Subject: |
[PATCH v2 5/6] target/ppc: Fix arguments to ppc_radix64_partition_scoped_xlate() |
Date: |
Thu, 14 May 2020 00:57:13 +0200 |
User-agent: |
StGit/unknown-version |
The last two arguments have the bool type. Also, we shouldn't raise an
exception when using gdbstub.
This was found while reading the code. Since it only affects the powernv
machine, I didn't dig further to find an actual bug.
Fixes: d04ea940c597 "target/ppc: Add support for Radix partition-scoped
translation"
Signed-off-by: Greg Kurz <address@hidden>
---
target/ppc/mmu-radix64.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/target/ppc/mmu-radix64.c b/target/ppc/mmu-radix64.c
index fb7dfe25ba6f..7ce37cb778db 100644
--- a/target/ppc/mmu-radix64.c
+++ b/target/ppc/mmu-radix64.c
@@ -339,7 +339,8 @@ static int ppc_radix64_process_scoped_xlate(PowerPCCPU
*cpu, int rwx,
*/
ret = ppc_radix64_partition_scoped_xlate(cpu, 0, eaddr, prtbe_addr,
pate, &h_raddr, &h_prot,
- &h_page_size, 1, 1);
+ &h_page_size, true,
+ cause_excp);
if (ret) {
return ret;
}
@@ -378,7 +379,8 @@ static int ppc_radix64_process_scoped_xlate(PowerPCCPU
*cpu, int rwx,
do {
ret = ppc_radix64_partition_scoped_xlate(cpu, 0, eaddr, pte_addr,
pate, &h_raddr, &h_prot,
- &h_page_size, 1, 1);
+ &h_page_size, true,
+ cause_excp);
if (ret) {
return ret;
}
- [PATCH v2 0/6] target/ppc: Various clean-up and fixes for radix64, Greg Kurz, 2020/05/13
- [PATCH v2 1/6] target/ppc: Pass const pointer to ppc_radix64_get_prot_amr(), Greg Kurz, 2020/05/13
- [PATCH v2 2/6] target/ppc: Pass const pointer to ppc_radix64_get_fully_qualified_addr(), Greg Kurz, 2020/05/13
- [PATCH v2 3/6] target/ppc: Don't initialize some local variables in ppc_radix64_xlate(), Greg Kurz, 2020/05/13
- [PATCH v2 5/6] target/ppc: Fix arguments to ppc_radix64_partition_scoped_xlate(),
Greg Kurz <=
- [PATCH v2 4/6] target/ppc: Add missing braces in ppc_radix64_partition_scoped_xlate(), Greg Kurz, 2020/05/13
- [PATCH v2 6/6] target/ppc: Don't update radix PTE R/C bits with gdbstub, Greg Kurz, 2020/05/13
- Re: [PATCH v2 0/6] target/ppc: Various clean-up and fixes for radix64, David Gibson, 2020/05/14