[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH-for-5.0 v2 09/11] hw/timer/stm32f2xx_timer: Remove dead assig
From: |
Alistair Francis |
Subject: |
Re: [PATCH-for-5.0 v2 09/11] hw/timer/stm32f2xx_timer: Remove dead assignment |
Date: |
Mon, 23 Mar 2020 08:53:09 -0700 |
On Sat, Mar 21, 2020 at 7:52 AM Philippe Mathieu-Daudé
<address@hidden> wrote:
>
> Fix warning reported by Clang static code analyzer:
>
> CC hw/timer/stm32f2xx_timer.o
> hw/timer/stm32f2xx_timer.c:225:9: warning: Value stored to 'value' is never
> read
> value = timer_val;
> ^ ~~~~~~~~~
>
> Reported-by: Clang Static Analyzer
> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
Reviewed-by: Alistair Francis <address@hidden>
Alistair
> ---
> hw/timer/stm32f2xx_timer.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/hw/timer/stm32f2xx_timer.c b/hw/timer/stm32f2xx_timer.c
> index 06ec8a02c2..ba8694dcd3 100644
> --- a/hw/timer/stm32f2xx_timer.c
> +++ b/hw/timer/stm32f2xx_timer.c
> @@ -222,7 +222,6 @@ static void stm32f2xx_timer_write(void *opaque, hwaddr
> offset,
> case TIM_PSC:
> timer_val = stm32f2xx_ns_to_ticks(s, now) - s->tick_offset;
> s->tim_psc = value & 0xFFFF;
> - value = timer_val;
> break;
> case TIM_CNT:
> timer_val = value;
> --
> 2.21.1
>
>
- Re: [PATCH-for-5.0 v2 04/11] hw/input/adb-kbd: Remove dead assignment, (continued)
- [PATCH-for-5.0 v2 05/11] hw/ide/sii3112: Remove dead assignment, Philippe Mathieu-Daudé, 2020/03/21
- [PATCH-for-5.0 v2 06/11] hw/isa/i82378: Remove dead assignment, Philippe Mathieu-Daudé, 2020/03/21
- [PATCH-for-5.0 v2 07/11] hw/gpio/aspeed_gpio: Remove dead assignment, Philippe Mathieu-Daudé, 2020/03/21
- [PATCH-for-5.0 v2 08/11] hw/timer/exynos4210_mct: Remove dead assignments, Philippe Mathieu-Daudé, 2020/03/21
- [PATCH-for-5.0 v2 09/11] hw/timer/stm32f2xx_timer: Remove dead assignment, Philippe Mathieu-Daudé, 2020/03/21
- Re: [PATCH-for-5.0 v2 09/11] hw/timer/stm32f2xx_timer: Remove dead assignment,
Alistair Francis <=
- [PATCH-for-5.0 v2 10/11] hw/timer/pxa2xx_timer: Add assertion to silent static analyzer warning, Philippe Mathieu-Daudé, 2020/03/21
- [PATCH-for-5.0 v2 11/11] hw/scsi/esp-pci: Remove dead assignment, Philippe Mathieu-Daudé, 2020/03/21
- Re: [PATCH-for-5.0 v2 00/11] misc: Trivial static code analyzer fixes, Philippe Mathieu-Daudé, 2020/03/21
- Re: [PATCH-for-5.0 v2 00/11] misc: Trivial static code analyzer fixes, Laurent Vivier, 2020/03/23