[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] spapr: Fix memory leak in h_client_architecture_support()
From: |
David Gibson |
Subject: |
Re: [PATCH] spapr: Fix memory leak in h_client_architecture_support() |
Date: |
Sun, 22 Mar 2020 16:32:05 +1100 |
On Sat, Mar 21, 2020 at 06:34:22PM +0100, Greg Kurz wrote:
> This is the only error path that needs to free the previously allocated
> ov1.
>
> Reported-by: Coverity (CID 1421924)
> Fixes: cbd0d7f36322 "spapr: Fail CAS if option vector table cannot be parsed"
> Signed-off-by: Greg Kurz <address@hidden>
Applied to ppc-forr-5.0.
> ---
> hw/ppc/spapr_hcall.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/hw/ppc/spapr_hcall.c b/hw/ppc/spapr_hcall.c
> index 40c86e91eb89..0d50fc911790 100644
> --- a/hw/ppc/spapr_hcall.c
> +++ b/hw/ppc/spapr_hcall.c
> @@ -1726,6 +1726,7 @@ static target_ulong
> h_client_architecture_support(PowerPCCPU *cpu,
> }
> ov5_guest = spapr_ovec_parse_vector(ov_table, 5);
> if (!ov5_guest) {
> + spapr_ovec_cleanup(ov1_guest);
> warn_report("guest didn't provide option vector 5");
> return H_PARAMETER;
> }
>
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
signature.asc
Description: PGP signature