[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 5/7] ppc/spapr: Allow FWNMI on TCG
From: |
David Gibson |
Subject: |
Re: [PATCH 5/7] ppc/spapr: Allow FWNMI on TCG |
Date: |
Tue, 10 Mar 2020 13:51:39 +1100 |
On Thu, Mar 05, 2020 at 02:59:36PM +1000, Nicholas Piggin wrote:
> There should no longer be a reason to prevent TCG providing FWNMI.
> System Reset interrupts are generated to the guest with nmi monitor
> command and H_SIGNAL_SYS_RESET. Machine Checks can not be injected
> currently, but this could be implemented with the mce monitor cmd
> similarly to i386.
>
> Signed-off-by: Nicholas Piggin <address@hidden>
Applied to ppc-for-5.0.
> ---
> hw/ppc/spapr_caps.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/hw/ppc/spapr_caps.c b/hw/ppc/spapr_caps.c
> index f626d769a0..679ae7959f 100644
> --- a/hw/ppc/spapr_caps.c
> +++ b/hw/ppc/spapr_caps.c
> @@ -516,10 +516,7 @@ static void cap_fwnmi_apply(SpaprMachineState *spapr,
> uint8_t val,
> return; /* Disabled by default */
> }
>
> - if (tcg_enabled()) {
> - warn_report("Firmware Assisted Non-Maskable Interrupts(FWNMI) not "
> - "supported in TCG");
> - } else if (kvm_enabled()) {
> + if (kvm_enabled()) {
> if (kvmppc_set_fwnmi() < 0) {
> error_setg(errp, "Firmware Assisted Non-Maskable
> Interrupts(FWNMI) "
> "not supported by KVM");
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
signature.asc
Description: PGP signature
- Re: [PATCH 1/7] ppc/spapr: Fix FWNMI machine check failure handling, (continued)
[PATCH 2/7] ppc/spapr: Change FWNMI names, Nicholas Piggin, 2020/03/05
[PATCH 3/7] ppc/spapr: Add FWNMI System Reset state, Nicholas Piggin, 2020/03/05
[PATCH 4/7] ppc/spapr: Fix FWNMI machine check interrupt delivery, Nicholas Piggin, 2020/03/05
[PATCH 5/7] ppc/spapr: Allow FWNMI on TCG, Nicholas Piggin, 2020/03/05
- Re: [PATCH 5/7] ppc/spapr: Allow FWNMI on TCG,
David Gibson <=
[PATCH 6/7] target/ppc: allow ppc_cpu_do_system_reset to take an alternate vector, Nicholas Piggin, 2020/03/05
[PATCH 7/7] ppc/spapr: Implement FWNMI System Reset delivery, Nicholas Piggin, 2020/03/05
Re: [PATCH 0/7] FWNMI fixes / changes, Greg Kurz, 2020/03/05