Re: [RFC PATCH 03/13] ppc/spapr: Disable FWNMI capability with TCG

[Nicholas Piggin]

David Gibson's on March 4, 2020 3:56 pm:
> On Wed, Mar 04, 2020 at 03:28:40PM +1000, Nicholas Piggin wrote:
>> Succeeding "ibm,nmi-register" RTAS calls but failing to actually
>> operate to specification is unhelpful at best. Disable the capability
>> when running on TCG.
> 
> Nack.
> 
> Providing (obviously) guest visibly different environments for TCG and
> KVM is something we strenously avoid (there are some legacy ones, but
> we're gradually fixing them).
> 
> In what way does TCG not do this correctly that's actually plausibly
> important?  AFAICT TCG should basically be equivalent to a correct
> implementation that never happens to deliver an NMI.
> 
> I explicitly asked Aravinda to make this only a warning, because it's
> a real pain if you have to explicitly override a setting in order to
> boot TCG at all.

Okay that makes sense. As far as I could see it was just that
interrupt delivery issue, so we can pull that and the enable for TCG
patch together and drop this one.

Thanks,
Nick