[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 18/29] migration/postcopy: enable random order target page arrival
From: |
Juan Quintela |
Subject: |
[PULL 18/29] migration/postcopy: enable random order target page arrival |
Date: |
Mon, 20 Jan 2020 11:33:29 +0100 |
From: Wei Yang <address@hidden>
After using number of target page received to track one host page, we
could have the capability to handle random order target page arrival in
one host page.
This is a preparation for enabling compress during postcopy.
Signed-off-by: Wei Yang <address@hidden>
Reviewed-by: Dr. David Alan Gilbert <address@hidden>
Reviewed-by: Juan Quintela <address@hidden>
Signed-off-by: Juan Quintela <address@hidden>
---
migration/ram.c | 18 ++++++++++--------
1 file changed, 10 insertions(+), 8 deletions(-)
diff --git a/migration/ram.c b/migration/ram.c
index 460abfa2c3..a7414170e5 100644
--- a/migration/ram.c
+++ b/migration/ram.c
@@ -4050,7 +4050,7 @@ static int ram_load_postcopy(QEMUFile *f)
MigrationIncomingState *mis = migration_incoming_get_current();
/* Temporary page that is later 'placed' */
void *postcopy_host_page = mis->postcopy_tmp_page;
- void *last_host = NULL;
+ void *this_host = NULL;
bool all_zero = false;
int target_pages = 0;
@@ -4097,24 +4097,26 @@ static int ram_load_postcopy(QEMUFile *f)
* that's moved into place later.
* The migration protocol uses, possibly smaller, target-pages
* however the source ensures it always sends all the components
- * of a host page in order.
+ * of a host page in one chunk.
*/
page_buffer = postcopy_host_page +
((uintptr_t)host & (block->page_size - 1));
/* If all TP are zero then we can optimise the place */
if (target_pages == 1) {
all_zero = true;
+ this_host = (void *)QEMU_ALIGN_DOWN((uintptr_t)host,
+ block->page_size);
} else {
/* not the 1st TP within the HP */
- if (host != (last_host + TARGET_PAGE_SIZE)) {
- error_report("Non-sequential target page %p/%p",
- host, last_host);
+ if (QEMU_ALIGN_DOWN((uintptr_t)host, block->page_size) !=
+ (uintptr_t)this_host) {
+ error_report("Non-same host page %p/%p",
+ host, this_host);
ret = -EINVAL;
break;
}
}
-
/*
* If it's the last part of a host page then we place the host
* page
@@ -4125,7 +4127,6 @@ static int ram_load_postcopy(QEMUFile *f)
}
place_source = postcopy_host_page;
}
- last_host = host;
switch (flags & ~RAM_SAVE_FLAG_CONTINUE) {
case RAM_SAVE_FLAG_ZERO:
@@ -4178,7 +4179,8 @@ static int ram_load_postcopy(QEMUFile *f)
if (!ret && place_needed) {
/* This gets called at the last target page in the host page */
- void *place_dest = host + TARGET_PAGE_SIZE - block->page_size;
+ void *place_dest = (void *)QEMU_ALIGN_DOWN((uintptr_t)host,
+ block->page_size);
if (all_zero) {
ret = postcopy_place_page_zero(mis, place_dest,
--
2.24.1
- [PULL 08/29] migration: Fix incorrect integer->float conversion caught by clang, (continued)
- [PULL 08/29] migration: Fix incorrect integer->float conversion caught by clang, Juan Quintela, 2020/01/20
- [PULL 09/29] migration: Fix the re-run check of the migrate-incoming command, Juan Quintela, 2020/01/20
- [PULL 10/29] misc: use QEMU_IS_ALIGNED, Juan Quintela, 2020/01/20
- [PULL 11/29] migration: add savevm_state_handler_remove(), Juan Quintela, 2020/01/20
- [PULL 12/29] migration: savevm_state_handler_insert: constant-time element insertion, Juan Quintela, 2020/01/20
- [PULL 13/29] migration/ram: Yield periodically to the main loop, Juan Quintela, 2020/01/20
- [PULL 14/29] migration/postcopy: reduce memset when it is zero page and matches_target_page_size, Juan Quintela, 2020/01/20
- [PULL 15/29] migration/postcopy: wait for decompress thread in precopy, Juan Quintela, 2020/01/20
- [PULL 16/29] migration/postcopy: count target page number to decide the place_needed, Juan Quintela, 2020/01/20
- [PULL 17/29] migration/postcopy: set all_zero to true on the first target page, Juan Quintela, 2020/01/20
- [PULL 18/29] migration/postcopy: enable random order target page arrival,
Juan Quintela <=
- [PULL 19/29] migration/postcopy: enable compress during postcopy, Juan Quintela, 2020/01/20
- [PULL 20/29] migration/multifd: clean pages after filling packet, Juan Quintela, 2020/01/20
- [PULL 21/29] migration/multifd: not use multifd during postcopy, Juan Quintela, 2020/01/20
- [PULL 22/29] migration/multifd: fix nullptr access in terminating multifd threads, Juan Quintela, 2020/01/20
- [PULL 23/29] migration/multifd: fix destroyed mutex access in terminating multifd threads, Juan Quintela, 2020/01/20
- [PULL 24/29] Bug #1829242 correction., Juan Quintela, 2020/01/20
- [PULL 25/29] migration: Define VMSTATE_INSTANCE_ID_ANY, Juan Quintela, 2020/01/20
- [PULL 26/29] migration: Change SaveStateEntry.instance_id into uint32_t, Juan Quintela, 2020/01/20
- [PULL 27/29] apic: Use 32bit APIC ID for migration instance ID, Juan Quintela, 2020/01/20
- [PULL 28/29] migration: Support QLIST migration, Juan Quintela, 2020/01/20