[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] ppc: Drop useless extern annotation for functions
From: |
David Gibson |
Subject: |
Re: [PATCH] ppc: Drop useless extern annotation for functions |
Date: |
Wed, 11 Dec 2019 11:35:02 +1100 |
User-agent: |
Mutt/1.12.1 (2019-06-15) |
On Tue, Dec 10, 2019 at 09:09:20AM +0100, Greg Kurz wrote:
Applied to ppc-for-5.0.
> Signed-off-by: Greg Kurz <address@hidden>
> ---
> include/hw/ppc/pnv_xscom.h | 22 +++++++++++-----------
> include/hw/ppc/spapr_vio.h | 6 +++---
> 2 files changed, 14 insertions(+), 14 deletions(-)
>
> diff --git a/include/hw/ppc/pnv_xscom.h b/include/hw/ppc/pnv_xscom.h
> index a40d2a2a2a98..1c1d76bf9be5 100644
> --- a/include/hw/ppc/pnv_xscom.h
> +++ b/include/hw/ppc/pnv_xscom.h
> @@ -109,16 +109,16 @@ typedef struct PnvXScomInterfaceClass {
> #define PNV10_XSCOM_PSIHB_BASE 0x3011D00
> #define PNV10_XSCOM_PSIHB_SIZE 0x100
>
> -extern void pnv_xscom_realize(PnvChip *chip, uint64_t size, Error **errp);
> -extern int pnv_dt_xscom(PnvChip *chip, void *fdt, int offset);
> -
> -extern void pnv_xscom_add_subregion(PnvChip *chip, hwaddr offset,
> - MemoryRegion *mr);
> -extern void pnv_xscom_region_init(MemoryRegion *mr,
> - struct Object *owner,
> - const MemoryRegionOps *ops,
> - void *opaque,
> - const char *name,
> - uint64_t size);
> +void pnv_xscom_realize(PnvChip *chip, uint64_t size, Error **errp);
> +int pnv_dt_xscom(PnvChip *chip, void *fdt, int offset);
> +
> +void pnv_xscom_add_subregion(PnvChip *chip, hwaddr offset,
> + MemoryRegion *mr);
> +void pnv_xscom_region_init(MemoryRegion *mr,
> + struct Object *owner,
> + const MemoryRegionOps *ops,
> + void *opaque,
> + const char *name,
> + uint64_t size);
>
> #endif /* PPC_PNV_XSCOM_H */
> diff --git a/include/hw/ppc/spapr_vio.h b/include/hw/ppc/spapr_vio.h
> index 72762ed16b70..ce6d9b0c6605 100644
> --- a/include/hw/ppc/spapr_vio.h
> +++ b/include/hw/ppc/spapr_vio.h
> @@ -80,10 +80,10 @@ struct SpaprVioBus {
> uint32_t next_reg;
> };
>
> -extern SpaprVioBus *spapr_vio_bus_init(void);
> -extern SpaprVioDevice *spapr_vio_find_by_reg(SpaprVioBus *bus, uint32_t reg);
> +SpaprVioBus *spapr_vio_bus_init(void);
> +SpaprVioDevice *spapr_vio_find_by_reg(SpaprVioBus *bus, uint32_t reg);
> void spapr_dt_vdevice(SpaprVioBus *bus, void *fdt);
> -extern gchar *spapr_vio_stdout_path(SpaprVioBus *bus);
> +gchar *spapr_vio_stdout_path(SpaprVioBus *bus);
>
> static inline void spapr_vio_irq_pulse(SpaprVioDevice *dev)
> {
>
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
signature.asc
Description: PGP signature