Re: [PATCH v3 1/3] mem: move nvdimm_device_list to utilities

[Shivaprasad G Bhat]

Hi Igor,


On 11/19/2019 12:43 PM, Igor Mammedov wrote:
> On Mon, 14 Oct 2019 13:37:37 -0500
> Shivaprasad G Bhat <address@hidden> wrote:
>
> > nvdimm_device_list is required for parsing the list for devices
> > in subsequent patches. Move it to common utility area.
> >
> > Signed-off-by: Shivaprasad G Bhat <address@hidden>
> > ---
> >   hw/acpi/nvdimm.c            |   28 +---------------------------
> >   include/qemu/nvdimm-utils.h |    7 +++++++
> >   util/Makefile.objs          |    1 +
> >   util/nvdimm-utils.c         |   29 +++++++++++++++++++++++++++++
> instead of creating new file, why not to move it to existing hw/mem/nvdimm.c?

That would break the build for mips-softmmu. The mips has 
CONFIG_ACPI_NVDIMM=y
and not CONFIG_NVDIMM. So, the build would break failing to fetch the 
definition from
hw/mem/nvdimm.c.

I have the patch here from v2 of the series,

https://github.com/ShivaprasadGBhat/qemu/commit/00512a25e4852f174fe6c07bc5acb5ee7027e3de

Thanks,
Shivaprasad