Re: [PATCH] spapr/kvm: Set default cpu model for all machine classes

[Peter Maydell]

On Wed, 30 Oct 2019 at 16:34, David Gibson <address@hidden> wrote:
>
> We have to set the default model of all machine classes, not just for the
> active one. Otherwise, "query-machines" will indicate the wrong CPU model
> ("qemu-s390x-cpu" instead of "host-s390x-cpu") as "default-cpu-type".
>
> s390x already fixed this in de60a92e "s390x/kvm: Set default cpu model for
> all machine classes".  This patch applies a similar fix for the pseries-*
> machine types on ppc64.

> Libvirt probes all machines via "-machine none,accel=kvm:tcg" and will
> currently see the wrong CPU model under KVM.

Isn't this a bug in libvirt ? The default CPU for one machine type
tells you nothing at all about the default machine for another CPU
type. Libvirt needs to ask about the default CPU for the machine
it's actually interested in, which is not likely to be "none".

thanks
-- PMM