[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4 4/7] ppc/pnv: Add a PnvChip pointer to PnvCore
From: |
Greg Kurz |
Subject: |
Re: [PATCH v4 4/7] ppc/pnv: Add a PnvChip pointer to PnvCore |
Date: |
Tue, 22 Oct 2019 17:38:23 +0200 |
On Tue, 22 Oct 2019 15:46:29 +0200
Cédric Le Goater <address@hidden> wrote:
> We will use it to reset the interrupt presenter from the CPU reset
> handler.
>
> Signed-off-by: Cédric Le Goater <address@hidden>
> ---
Reviewed-by: Greg Kurz <address@hidden>
> include/hw/ppc/pnv_core.h | 3 +++
> hw/ppc/pnv_core.c | 3 ++-
> 2 files changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/include/hw/ppc/pnv_core.h b/include/hw/ppc/pnv_core.h
> index bfbd2ec42aa6..55eee95104da 100644
> --- a/include/hw/ppc/pnv_core.h
> +++ b/include/hw/ppc/pnv_core.h
> @@ -31,6 +31,8 @@
> #define PNV_CORE_GET_CLASS(obj) \
> OBJECT_GET_CLASS(PnvCoreClass, (obj), TYPE_PNV_CORE)
>
> +typedef struct PnvChip PnvChip;
> +
> typedef struct PnvCore {
> /*< private >*/
> CPUCore parent_obj;
> @@ -38,6 +40,7 @@ typedef struct PnvCore {
> /*< public >*/
> PowerPCCPU **threads;
> uint32_t pir;
> + PnvChip *chip;
>
> MemoryRegion xscom_regs;
> } PnvCore;
> diff --git a/hw/ppc/pnv_core.c b/hw/ppc/pnv_core.c
> index 9f981a4940e6..cc17bbfed829 100644
> --- a/hw/ppc/pnv_core.c
> +++ b/hw/ppc/pnv_core.c
> @@ -222,6 +222,7 @@ static void pnv_core_realize(DeviceState *dev, Error
> **errp)
> "required link 'chip' not found: ");
> return;
> }
> + pc->chip = PNV_CHIP(chip);
>
> pc->threads = g_new(PowerPCCPU *, cc->nr_threads);
> for (i = 0; i < cc->nr_threads; i++) {
> @@ -243,7 +244,7 @@ static void pnv_core_realize(DeviceState *dev, Error
> **errp)
> }
>
> for (j = 0; j < cc->nr_threads; j++) {
> - pnv_realize_vcpu(pc->threads[j], PNV_CHIP(chip), &local_err);
> + pnv_realize_vcpu(pc->threads[j], pc->chip, &local_err);
> if (local_err) {
> goto err;
> }
- [PATCH v4 0/7] ppc: reset the interrupt presenter from the CPU reset handler, Cédric Le Goater, 2019/10/22
- [PATCH v4 1/7] spapr: move CPU reset after presenter creation, Cédric Le Goater, 2019/10/22
- [PATCH v4 2/7] spapr_cpu_core: Implement DeviceClass::reset, Cédric Le Goater, 2019/10/22
- [PATCH v4 3/7] ppc/pnv: Introduce a PnvCore reset handler, Cédric Le Goater, 2019/10/22
- [PATCH v4 4/7] ppc/pnv: Add a PnvChip pointer to PnvCore, Cédric Le Goater, 2019/10/22
- Re: [PATCH v4 4/7] ppc/pnv: Add a PnvChip pointer to PnvCore,
Greg Kurz <=
- [PATCH v4 5/7] ppc: Reset the interrupt presenter from the CPU reset handler, Cédric Le Goater, 2019/10/22
- [PATCH v4 6/7] ppc/pnv: Fix naming of routines realizing the CPUs, Cédric Le Goater, 2019/10/22
- [PATCH v4 7/7] spapr/xive: Set the OS CAM line at reset, Cédric Le Goater, 2019/10/22