[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[RFC PATCH v3 2/9] tests/acceptance: Fix wait_for_console_pattern() hang
From: |
Philippe Mathieu-Daudé |
Subject: |
[RFC PATCH v3 2/9] tests/acceptance: Fix wait_for_console_pattern() hangs |
Date: |
Thu, 17 Oct 2019 18:52:32 +0200 |
From: Philippe Mathieu-Daudé <address@hidden>
Because of a possible deadlock (QEMU waiting for the socket to
become writable) let's close the console socket as soon as we
stop to use it.
Suggested-by: Cleber Rosa <address@hidden>
Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
---
tests/acceptance/avocado_qemu/__init__.py | 1 +
1 file changed, 1 insertion(+)
diff --git a/tests/acceptance/avocado_qemu/__init__.py
b/tests/acceptance/avocado_qemu/__init__.py
index a0fe16e47f..39f72945cd 100644
--- a/tests/acceptance/avocado_qemu/__init__.py
+++ b/tests/acceptance/avocado_qemu/__init__.py
@@ -75,6 +75,7 @@ def wait_for_console_pattern(test, success_message,
if success_message in msg:
break
if failure_message in msg:
+ console.close()
fail = 'Failure message found in console: %s' % failure_message
test.fail(fail)
--
2.21.0
- [PATCH v3 0/9] tests/acceptance: Add tests for the PReP/40p machine, Philippe Mathieu-Daudé, 2019/10/17
- [PATCH v3 1/9] Acceptance tests: refactor wait_for_console_pattern, Philippe Mathieu-Daudé, 2019/10/17
- [PATCH v3 3/9] tests/acceptance: Send <carriage return> on serial lines, Philippe Mathieu-Daudé, 2019/10/17
- [RFC PATCH v3 2/9] tests/acceptance: Fix wait_for_console_pattern() hangs,
Philippe Mathieu-Daudé <=
- [PATCH v3 4/9] tests/acceptance: Refactor exec_command_and_wait_for_pattern(), Philippe Mathieu-Daudé, 2019/10/17
- [PATCH v3 5/9] tests/acceptance: Add test that runs NetBSD 4.0 installer on PRep/40p, Philippe Mathieu-Daudé, 2019/10/17
- [PATCH v3 6/9] tests/acceptance: Test Open Firmware on the PReP/40p, Philippe Mathieu-Daudé, 2019/10/17
- [PATCH v3 7/9] tests/acceptance: Test OpenBIOS on the PReP/40p, Philippe Mathieu-Daudé, 2019/10/17
- [PATCH v3 9/9] .travis.yml: Let the avocado job run the 40p tests, Philippe Mathieu-Daudé, 2019/10/17
- [PATCH v3 8/9] tests/acceptance: Test Sandalfoot initrd on the PReP/40p, Philippe Mathieu-Daudé, 2019/10/17