[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] xics: Make some device types not user creatable
|
From: |
David Gibson |
|
Subject: |
Re: [PATCH] xics: Make some device types not user creatable |
|
Date: |
Sat, 5 Oct 2019 20:21:33 +1000 |
|
User-agent: |
Mutt/1.12.1 (2019-06-15) |
On Fri, Oct 04, 2019 at 10:37:47AM +0200, Greg Kurz wrote:
> Some device types of the XICS model are exposed to the QEMU command
> line:
>
> $ ppc64-softmmu/qemu-system-ppc64 -device help | grep ic[sp]
> name "icp"
> name "ics"
> name "ics-spapr"
> name "pnv-icp", desc "PowerNV ICP"
>
> These are internal devices that shouldn't be instantiable by the
> user. By the way, they can't be because their respective realize
> functions expect link properties that can't be set from the command
> line:
>
> qemu-system-ppc64: -device icp: required link 'xics' not found:
> Property '.xics' not found
> qemu-system-ppc64: -device ics: required link 'xics' not found:
> Property '.xics' not found
> qemu-system-ppc64: -device ics-spapr: required link 'xics' not found:
> Property '.xics' not found
> qemu-system-ppc64: -device pnv-icp: required link 'xics' not found:
> Property '.xics' not found
>
> Hide them by setting dc->user_creatable to false in the base class
> "icp" and "ics" init functions.
>
> Signed-off-by: Greg Kurz <address@hidden>
Applied to ppc-for-4.2.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
signature.asc
Description: PGP signature