Re: [PATCH 2/7] spapr, xive: Turn "nr-ends" property into "nr-servers" property

[Cédric Le Goater]

>> @@ -283,11 +292,13 @@ static void spapr_xive_realize(DeviceState *dev, Error 
>> **errp)
>>          return;
>>      }
>>  
>> -    if (!xive->nr_ends) {
>> -        error_setg(errp, "Number of interrupt needs to be greater 0");
>> +    if (!xive->nr_servers) {
>> +        error_setg(errp, "Number of interrupt servers must be greater than 
>> 0");
>>          return;
>>      }
>>  
>> +    xive->nr_ends = spapr_xive_vcpu_id_to_end_idx(xive->nr_servers);
> 
> I'd prefer not to store both nr_servers and nr_servers * 8 in the
> structure.  I think you just want xive->nr_servers, then derive it any
> any places that current look at xive->nr_ends.

Yes I agree. This is a small change.

C.