Re: [PATCH v3 00/25] error: auto propagated local_err

[Vladimir Sementsov-Ogievskiy]

25.09.2019 13:09, address@hidden wrote:
> Patchew URL: https://patchew.org/QEMU/address@hidden/
> 
> 
> 
> Hi,
> 
> This series seems to have some coding style problems. See output below for
> more information:
> 

[..]

> 
> === OUTPUT BEGIN ===
> 1/25 Checking commit 2493069b7603 (errp: rename errp to errp_in where it is 
> IN-argument)
> 2/25 Checking commit 118f61787279 (hw/core/loader-fit: fix freeing errp in 
> fit_load_fdt)
> 3/25 Checking commit 1f5d98328d6c (net/net: fix local variable shadowing in 
> net_client_init)
> 4/25 Checking commit 4c37d5c6d228 (error: auto propagated local_err)
> ERROR: Macros with multiple statements should be enclosed in a do - while loop

In general - yes. But this is a very special case and it worth an exception of 
the rule.

> #69: FILE: include/qapi/error.h:355:
> +#define ERRP_FUNCTION_BEGIN() \
> +g_auto(ErrorPropagator) __auto_errp_prop = {.errp = errp}; \
> +errp = ((errp == NULL || *errp == error_fatal) ? \
> +    &__auto_errp_prop.local_err : errp)
> 
> total: 1 errors, 0 warnings, 41 lines checked



-- 
Best regards,
Vladimir