[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-ppc] [PATCH] ppc: Use FPSCR defines instead of constants
|
From: |
Richard Henderson |
|
Subject: |
Re: [Qemu-ppc] [PATCH] ppc: Use FPSCR defines instead of constants |
|
Date: |
Wed, 18 Sep 2019 08:09:39 -0700 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 |
On 9/18/19 7:32 AM, Paul A. Clarke wrote:
> From: "Paul A. Clarke" <address@hidden>
>
> There are FPSCR-related defines in target/ppc/cpu.h which can be used in
> place of constants and explicit shifts which arguably improve the code a
> bit in places.
>
> Signed-off-by: Paul A. Clarke <address@hidden>
> ---
> I confirmed that the generated assembly is identical before and after
> the patch.
>
> target/ppc/dfp_helper.c | 8 ++--
> target/ppc/fpu_helper.c | 122
> ++++++++++++++++++++++++------------------------
> 2 files changed, 65 insertions(+), 65 deletions(-)
Reviewed-by: Richard Henderson <address@hidden>
r~