Re: [Qemu-ppc] [Qemu-devel] [PATCH v2 3/6] tests/acceptance: Test OpenBIOS on the PReP/40p

[Artyom Tarasenko]

On Tue, Sep 17, 2019 at 11:44 AM Philippe Mathieu-Daudé
<address@hidden> wrote:
>
> On 9/17/19 11:31 AM, Alex Bennée wrote:
> > Cleber Rosa <address@hidden> writes:
> >> On Sun, Sep 15, 2019 at 11:19:37PM +0200, Philippe Mathieu-Daudé wrote:
> >>> User case from:
> >>> https://mail.coreboot.org/pipermail/openbios/2018-May/010360.html
> >>>
> >>> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
> >>> ---
> >>>  tests/acceptance/ppc_prep_40p.py | 32 ++++++++++++++++++++++++++++++++
> >>>  1 file changed, 32 insertions(+)
> >>>
> >>> diff --git a/tests/acceptance/ppc_prep_40p.py 
> >>> b/tests/acceptance/ppc_prep_40p.py
> >>> index a0eac40d9f..87b5311b89 100644
> >>> --- a/tests/acceptance/ppc_prep_40p.py
> >>> +++ b/tests/acceptance/ppc_prep_40p.py
> >>> @@ -82,3 +82,35 @@ class IbmPrep40pMachine(Test):
> >>>          self.wait_for_console_pattern(fw_banner)
> >>>          prompt_msg = 'Type any key to interrupt automatic startup'
> >>>          self.wait_for_console_pattern(prompt_msg)
> >>> +
> >>> +    def test_openbios_192m(self):
> >>> +        """
> >>> +        :avocado: tags=arch:ppc
> >>> +        :avocado: tags=machine:40p
> >>> +        """
> >>> +        self.vm.set_machine('40p')
> >>> +        self.vm.set_console()
> >>> +        self.vm.add_args('-m', '192')
> >>
> >> Is 192 a magic number (some kind of limit)?  Or just a value to check
> >> against later?
> >
> > Just the memory configured for the machine, checked bellow. Or are you
> > wondering why 192m and not any other amount?
>
> The machine default is 128MiB. The firmware asks the memory controller
> how many SIMMs of 8MiB are inserted. We can run OpenBIOS with 128MiB,
> but by specifying a different default in this test, we also test the
> memory controller device :)
>
> Since this is not obvious I'll add a comment.

Are you sure OpenBIOS does it? Doesn't it get the info from the qemu fw device?
At least when making OFW I haven't found a way to the info from the
memory controller. I think it's not implemented. Or at least wasn't
back then.
And since I wanted to be compatible with the real hw, which doesn't
have a fw device, I just kept the hardcoded value in OFW.
If it's in the MC meanwhile, I can add the check to OFW as well.

> >>> +
> >>> +        self.vm.launch()
> >>> +        self.wait_for_console_pattern('>> OpenBIOS')
> >>> +        self.wait_for_console_pattern('>> Memory: 192M')
> >>> +        self.wait_for_console_pattern('>> CPU type PowerPC,604')
> >>> +
> >>
> >> On my testing, this is a very stable test, I'm only getting PASSes.
> > <snip>
> >
> > --
> > Alex Bennée
> >



-- 
Regards,
Artyom Tarasenko

SPARC and PPC PReP under qemu blog: http://tyom.blogspot.com/search/label/qemu