[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-ppc] [PATCH v2] ppc: Add support for 'mffscrn', 'mffscrni' ins
|
From: |
Richard Henderson |
|
Subject: |
Re: [Qemu-ppc] [PATCH v2] ppc: Add support for 'mffscrn', 'mffscrni' instructions |
|
Date: |
Sat, 14 Sep 2019 11:00:15 -0400 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 |
On 9/14/19 10:58 AM, Richard Henderson wrote:
> On 9/12/19 8:54 AM, Paul A. Clarke wrote:
>> +static void gen_helper_mffscrn(DisasContext *ctx, TCGv_i64 t1)
>> +{
>> + TCGv_i64 t0 = tcg_temp_new_i64();
>> + TCGv_i32 mask = tcg_const_i32(0x0001);
>> +
>> + gen_reset_fpstatus();
>> + tcg_gen_extu_tl_i64(t0, cpu_fpscr);
>> + tcg_gen_andi_i64(t0, t0, FP_MODE | FP_ENABLES);
>
> Missing the decimal rounding mode (DRN) field at 29:31.
>
> Otherwise,
Dang it, <ctrl-v><ctrl-enter> in the wrong order.
Reviewed-by: Richard Henderson <address@hidden>
r~