[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-ppc] [PATCH 4/7] spapr: Skip leading zeroes from memory@ DT no
From: |
Greg Kurz |
Subject: |
Re: [Qemu-ppc] [PATCH 4/7] spapr: Skip leading zeroes from memory@ DT node names |
Date: |
Wed, 11 Sep 2019 10:01:19 +0200 |
On Wed, 11 Sep 2019 14:04:49 +1000
David Gibson <address@hidden> wrote:
> From: Alexey Kardashevskiy <address@hidden>
>
> The device tree build by QEMU at the machine reset time is used by SLOF
> to build its internal device tree but the node names are not preserved
> exactly so when QEMU provides a device tree update in response to H_CAS,
> it might become tricky to match a node from the update blob to
> the actual node in SLOF.
>
> This removed leading zeroes from "memory@" nodes and makes
> the DTC checker happy.
>
> Signed-off-by: Alexey Kardashevskiy <address@hidden>
> Signed-off-by: David Gibson <address@hidden>
> ---
Reviewed-by: Greg Kurz <address@hidden>
> hw/ppc/spapr.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c
> index d93dacd483..d072c2aa3d 100644
> --- a/hw/ppc/spapr.c
> +++ b/hw/ppc/spapr.c
> @@ -386,7 +386,7 @@ static int spapr_populate_memory_node(void *fdt, int
> nodeid, hwaddr start,
> mem_reg_property[0] = cpu_to_be64(start);
> mem_reg_property[1] = cpu_to_be64(size);
>
> - sprintf(mem_name, "memory@" TARGET_FMT_lx, start);
> + sprintf(mem_name, "memory@%" HWADDR_PRIx, start);
> off = fdt_add_subnode(fdt, 0, mem_name);
> _FDT(off);
> _FDT((fdt_setprop_string(fdt, off, "device_type", "memory")));
- Re: [Qemu-ppc] [PATCH 1/7] spapr: Simplify handling of pre ISA 3.0 guest workaround handling, (continued)
- [Qemu-ppc] [PATCH 2/7] spapr: Move handling of special NVLink numa node from reset to init, David Gibson, 2019/09/11
- [Qemu-ppc] [PATCH 7/7] spapr: Perform machine reset in a more sensible order, David Gibson, 2019/09/11
- [Qemu-ppc] [PATCH 4/7] spapr: Skip leading zeroes from memory@ DT node names, David Gibson, 2019/09/11
- Re: [Qemu-ppc] [PATCH 4/7] spapr: Skip leading zeroes from memory@ DT node names,
Greg Kurz <=
- [Qemu-ppc] [PATCH 3/7] spapr: Fixes a leak in CAS, David Gibson, 2019/09/11
- [Qemu-ppc] [PATCH 6/7] spapr: Stop providing RTAS blob, David Gibson, 2019/09/11