|
From: | Tao Xu |
Subject: | Re: [Qemu-ppc] [Qemu-devel] [PATCH] numa: Introduce MachineClass::auto_enable_numa for implicit NUMA node |
Date: | Thu, 5 Sep 2019 08:57:16 +0800 |
User-agent: | Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 |
On 9/5/2019 4:43 AM, Eduardo Habkost wrote:
On Wed, Sep 04, 2019 at 02:22:39PM +0800, Tao Xu wrote:On 9/4/2019 1:52 AM, Eduardo Habkost wrote:On Mon, Aug 05, 2019 at 03:13:02PM +0800, Tao Xu wrote:Add MachineClass::auto_enable_numa field. When it is true, a NUMA node is expected to be created implicitly. Acked-by: David Gibson <address@hidden> Suggested-by: Igor Mammedov <address@hidden> Suggested-by: Eduardo Habkost <address@hidden> Signed-off-by: Tao Xu <address@hidden>This introduces spurious warnings when running qemu-system-ppc64. See: https://lore.kernel.org/qemu-devel/CAFEAcA-AvFS2cbDH-t5SxgY9hA=address@hidden/ To reproduce it, just run 'qemu-system-ppc64 -machine pseries' without any -numa arguments. I have removed this patch from machine-next so it won't block the existing pull request.I got it. If default splitting of RAM between nodes is deprecated, this patch can't reuse the splitting code. I agree with droping this patch.Probably all we need to fix this issue is to replace NumaNodeOptions node = { }; with NumaNodeOptions node = { .size = ram_size }; in the auto_enable_numa block. Do you plan to send v2?
OK, thank you for your suggestion. I will fix it and send v2.
[Prev in Thread] | Current Thread | [Next in Thread] |