[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-ppc] [PATCH 2/3] spapr/pci: Free MSIs during reset
From: |
David Gibson |
Subject: |
Re: [Qemu-ppc] [PATCH 2/3] spapr/pci: Free MSIs during reset |
Date: |
Sun, 28 Jul 2019 17:06:39 +1000 |
User-agent: |
Mutt/1.12.0 (2019-05-25) |
On Fri, Jul 26, 2019 at 04:44:44PM +0200, Greg Kurz wrote:
> When the machine is reset, the MSI bitmap is cleared but the allocated
> MSIs are not freed. Some operating systems, such as AIX, can detect the
> previous configuration and assert.
>
> Empty the MSI cache, this performs the needed cleanup.
>
> Signed-off-by: Greg Kurz <address@hidden>
Applied to ppc-for-4.2, thanks.
> ---
> hw/ppc/spapr_pci.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/hw/ppc/spapr_pci.c b/hw/ppc/spapr_pci.c
> index bc22568bfa71..e45507bf2b53 100644
> --- a/hw/ppc/spapr_pci.c
> +++ b/hw/ppc/spapr_pci.c
> @@ -2078,6 +2078,8 @@ static void spapr_phb_reset(DeviceState *qdev)
> if (spapr_phb_eeh_available(SPAPR_PCI_HOST_BRIDGE(qdev))) {
> spapr_phb_vfio_reset(qdev);
> }
> +
> + g_hash_table_remove_all(sphb->msi);
> }
>
> static Property spapr_phb_properties[] = {
>
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
signature.asc
Description: PGP signature