[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-ppc] [Qemu-block] [PATCH-for-4.1? 6/7] vl: Rewrite a fall thro
From: |
John Snow |
Subject: |
Re: [Qemu-ppc] [Qemu-block] [PATCH-for-4.1? 6/7] vl: Rewrite a fall through comment |
Date: |
Wed, 24 Jul 2019 20:28:25 -0400 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 |
On 7/19/19 9:14 AM, Philippe Mathieu-Daudé wrote:
> GCC9 is confused by this comment when building with CFLAG
> -Wimplicit-fallthrough=2:
>
> vl.c: In function ‘qemu_ref_timedate’:
> vl.c:773:15: error: this statement may fall through
> [-Werror=implicit-fallthrough=]
> 773 | value -= rtc_realtime_clock_offset;
> | ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~
> vl.c:775:5: note: here
> 775 | case QEMU_CLOCK_VIRTUAL:
> | ^~~~
> cc1: all warnings being treated as errors
>
> Rewrite the comment using 'fall through' which is recognized by
> GCC and static analyzers.
>
> Reported-by: Stefan Weil <address@hidden>
> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
> ---
> vl.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/vl.c b/vl.c
> index a5808f9a02..f5cf71e3b4 100644
> --- a/vl.c
> +++ b/vl.c
> @@ -771,7 +771,7 @@ static time_t qemu_ref_timedate(QEMUClockType clock)
> switch (clock) {
> case QEMU_CLOCK_REALTIME:
> value -= rtc_realtime_clock_offset;
> - /* no break */
> + /* fall through */
> case QEMU_CLOCK_VIRTUAL:
> value += rtc_ref_start_datetime;
> break;
>
Reviewed-by: John Snow <address@hidden>
- [Qemu-ppc] [PATCH-for-4.1 3/7] hw/block/pflash_cfi02: Rewrite a fall through comment, (continued)
- [Qemu-ppc] [PATCH-for-4.1? 4/7] hw/ipmi: Rewrite a fall through comment, Philippe Mathieu-Daudé, 2019/07/19
- [Qemu-ppc] [PATCH-for-4.1? 5/7] target/ppc: Rewrite a fall through comment, Philippe Mathieu-Daudé, 2019/07/19
- [Qemu-ppc] [PATCH-for-4.1? 6/7] vl: Rewrite a fall through comment, Philippe Mathieu-Daudé, 2019/07/19
- Re: [Qemu-ppc] [Qemu-block] [PATCH-for-4.1? 6/7] vl: Rewrite a fall through comment,
John Snow <=
- [Qemu-ppc] [PATCH-for-4.1? 7/7] spapr_events: Rewrite a fall through comment, Philippe Mathieu-Daudé, 2019/07/19