[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-ppc] [PATCH v2 3/4] ppc: fix leak in h_client_architecture_sup
From: |
Greg Kurz |
Subject: |
Re: [Qemu-ppc] [PATCH v2 3/4] ppc: fix leak in h_client_architecture_support |
Date: |
Wed, 17 Jul 2019 12:47:55 +0200 |
On Wed, 17 Jul 2019 03:20:31 -0500
Shivaprasad G Bhat <address@hidden> wrote:
> Free all SpaprOptionVector local pointers after use.
>
> Signed-off-by: Shivaprasad G Bhat <address@hidden>
> ---
Reviewed-by: Greg Kurz <address@hidden>
> hw/ppc/spapr_hcall.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/hw/ppc/spapr_hcall.c b/hw/ppc/spapr_hcall.c
> index 6808d4cda8..71cfe7c41d 100644
> --- a/hw/ppc/spapr_hcall.c
> +++ b/hw/ppc/spapr_hcall.c
> @@ -1612,6 +1612,7 @@ static target_ulong
> h_client_architecture_support(PowerPCCPU *cpu,
> ov5_updates = spapr_ovec_new();
> spapr->cas_reboot = spapr_ovec_diff(ov5_updates,
> ov5_cas_old, spapr->ov5_cas);
> + spapr_ovec_cleanup(ov5_cas_old);
> /* Now that processing is finished, set the radix/hash bit for the
> * guest if it requested a valid mode; otherwise terminate the boot. */
> if (guest_radix) {
> @@ -1629,6 +1630,7 @@ static target_ulong
> h_client_architecture_support(PowerPCCPU *cpu,
> }
> spapr->cas_legacy_guest_workaround = !spapr_ovec_test(ov1_guest,
> OV1_PPC_3_00);
> + spapr_ovec_cleanup(ov1_guest);
> if (!spapr->cas_reboot) {
> /* If spapr_machine_reset() did not set up a HPT but one is necessary
> * (because the guest isn't going to use radix) then set it up here.
> */
>
>