[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-ppc] [PULL 1/4] virtio-gpu: fix unmap in error path
From: |
Gerd Hoffmann |
Subject: |
[Qemu-ppc] [PULL 1/4] virtio-gpu: fix unmap in error path |
Date: |
Wed, 3 Jul 2019 10:54:13 +0200 |
We land here in case not everything we've asked for could be mapped.
So unmap only the bytes which have actually been mapped.
Also we didn't access anything, so acces_len can be 0.
Reported-by: Laszlo Ersek <address@hidden>
Signed-off-by: Gerd Hoffmann <address@hidden>
Reviewed-by: Laszlo Ersek <address@hidden>
Reviewed-by: Li Qiang <address@hidden>
Message-id: address@hidden
---
hw/display/virtio-gpu.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/display/virtio-gpu.c b/hw/display/virtio-gpu.c
index 2b0f66b1d68d..475a018c027c 100644
--- a/hw/display/virtio-gpu.c
+++ b/hw/display/virtio-gpu.c
@@ -1048,9 +1048,9 @@ static int virtio_gpu_load(QEMUFile *f, void *opaque,
size_t size,
if (res->iov[i].iov_base) {
dma_memory_unmap(VIRTIO_DEVICE(g)->dma_as,
res->iov[i].iov_base,
- res->iov[i].iov_len,
+ len,
DMA_DIRECTION_TO_DEVICE,
- res->iov[i].iov_len);
+ 0);
}
/* ...and the mappings for previous loop iterations */
res->iov_cnt = i;
--
2.18.1
- [Qemu-ppc] [PULL 0/4] Vga 20190703 patches, Gerd Hoffmann, 2019/07/03
- [Qemu-ppc] [PULL 3/4] hw/i2c/bitbang_i2c: Use in-place rather than malloc'd bitbang_i2c_interface struct, Gerd Hoffmann, 2019/07/03
- [Qemu-ppc] [PULL 2/4] virtio-gpu: check if the resource already exists in virtio_gpu_load(), Gerd Hoffmann, 2019/07/03
- [Qemu-ppc] [PULL 1/4] virtio-gpu: fix unmap in error path,
Gerd Hoffmann <=
- [Qemu-ppc] [PULL 4/4] Add ati vgabios to INSTALL_BLOBS., Gerd Hoffmann, 2019/07/03
- Re: [Qemu-ppc] [PULL 0/4] Vga 20190703 patches, Peter Maydell, 2019/07/04
- Re: [Qemu-ppc] [Qemu-devel] [PULL 0/4] Vga 20190703 patches, no-reply, 2019/07/04
- Re: [Qemu-ppc] [Qemu-devel] [PULL 0/4] Vga 20190703 patches, no-reply, 2019/07/04
- Re: [Qemu-ppc] [Qemu-devel] [PULL 0/4] Vga 20190703 patches, no-reply, 2019/07/04