[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-ppc] [PATCH v2 8/9] hw/block/pflash_cfi01: Replace DPRINTF by
From: |
Alistair Francis |
Subject: |
Re: [Qemu-ppc] [PATCH v2 8/9] hw/block/pflash_cfi01: Replace DPRINTF by qemu_log_mask(GUEST_ERROR) |
Date: |
Tue, 2 Jul 2019 09:15:07 -0700 |
On Mon, Jul 1, 2019 at 5:16 PM Philippe Mathieu-Daudé <address@hidden> wrote:
>
> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
Reviewed-by: Alistair Francis <address@hidden>
Alistair
> ---
> hw/block/pflash_cfi01.c | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/hw/block/pflash_cfi01.c b/hw/block/pflash_cfi01.c
> index f50d0a9d37..e891112b67 100644
> --- a/hw/block/pflash_cfi01.c
> +++ b/hw/block/pflash_cfi01.c
> @@ -286,7 +286,9 @@ static uint32_t pflash_read(PFlashCFI01 *pfl, hwaddr
> offset,
> switch (pfl->cmd) {
> default:
> /* This should never happen : reset state & treat it as a read */
> - DPRINTF("%s: unknown command state: %x\n", __func__, pfl->cmd);
> + qemu_log_mask(LOG_GUEST_ERROR, "%s: Invalid state, "
> + "wcycle %d cmd 0x02%x\n",
> + __func__, pfl->wcycle, pfl->cmd);
> pfl->wcycle = 0;
> pfl->cmd = 0xff;
> /* fall through to read code */
> @@ -631,7 +633,9 @@ static void pflash_write(PFlashCFI01 *pfl, hwaddr offset,
> break;
> default:
> /* Should never happen */
> - DPRINTF("%s: invalid write state\n", __func__);
> + qemu_log_mask(LOG_GUEST_ERROR, "%s: Invalid state, "
> + "wcycle %d cmd (0x02%x -> value 0x02%x)\n",
> + __func__, pfl->wcycle, pfl->cmd, value);
> goto mode_read_array;
> }
> return;
> --
> 2.20.1
>
[Qemu-ppc] [PATCH v2 6/9] hw/block/pflash_cfi01: Simplify CFI_QUERY processing, Philippe Mathieu-Daudé, 2019/07/01
[Qemu-ppc] [PATCH v2 9/9] hw/block/pflash_cfi01: Hold the PRI table offset in a variable, Philippe Mathieu-Daudé, 2019/07/01
[Qemu-ppc] [PATCH v2 8/9] hw/block/pflash_cfi01: Replace DPRINTF by qemu_log_mask(GUEST_ERROR), Philippe Mathieu-Daudé, 2019/07/01
- Re: [Qemu-ppc] [PATCH v2 8/9] hw/block/pflash_cfi01: Replace DPRINTF by qemu_log_mask(GUEST_ERROR),
Alistair Francis <=
[Qemu-ppc] [PATCH v2 7/9] hw/block/pflash_cfi01: Improve command comments, Philippe Mathieu-Daudé, 2019/07/01
Re: [Qemu-ppc] [Qemu-devel] [PATCH v2 0/9] hw/block/pflash_cfi01: Add DeviceReset() handler, no-reply, 2019/07/02
Re: [Qemu-ppc] [Qemu-devel] [PATCH v2 0/9] hw/block/pflash_cfi01: Add DeviceReset() handler, Laszlo Ersek, 2019/07/02