Re: [Qemu-ppc] [Qemu-devel] [QEMU-PPC] [PATCH v2] powerpc/spapr: Add host threads parameter to ibm, get_system_parameter

[no-reply]

Patchew URL: https://patchew.org/QEMU/address@hidden/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Message-id: address@hidden
Type: series
Subject: [Qemu-devel] [QEMU-PPC] [PATCH v2] powerpc/spapr: Add host threads 
parameter to ibm, get_system_parameter

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Switched to a new branch 'test'
83350a8 powerpc/spapr: Add host threads parameter to ibm, get_system_parameter

=== OUTPUT BEGIN ===
ERROR: braces {} are necessary for all arms of this statement
#42: FILE: hw/ppc/spapr_rtas.c:243:
+    if (!kvm_enabled())
[...]

ERROR: braces {} are necessary for all arms of this statement
#47: FILE: hw/ppc/spapr_rtas.c:248:
+    if (!dir)
[...]

ERROR: braces {} are necessary for all arms of this statement
#72: FILE: hw/ppc/spapr_rtas.c:273:
+        if (subcores)
[...]

total: 3 errors, 0 warnings, 71 lines checked

Commit 83350a8ff0c8 (powerpc/spapr: Add host threads parameter to ibm, 
get_system_parameter) has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/address@hidden/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to address@hidden