Re: [Qemu-ppc] [Qemu-devel] [PATCH 1/2] monitor: Add dump-stack command

[Markus Armbruster]

"Dr. David Alan Gilbert" <address@hidden> writes:

> * Markus Armbruster (address@hidden) wrote:
>> Suraj Jitindar Singh <address@hidden> writes:
>> 
>> > Add a monitor command "dump-stack" to be used to dump the stack for the
>> > current cpu.
>> 
>> I guess this is just for debugging.  Correct?
>> 
>> Shouldn't this be "info stack", to match "info registers" and "info
>> cpustats"?
>
> Since this is primarily about walking the guests stack frames and not
> walking qemu internal data structures, I think it's probably OK to be
> a dump-stack rather than an info subcommand.

Well, "info registers" is also about the guest's state and not QEMU
internal state.  Arguably, so are "info pic", "info tlb", ...

We have a long-standing tradition of using "info" for "pure"
information-retrieving commands.  I rather like that pattern.

Ultimately your choice as the HMP maintainer, of course.